Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly extract parent path on Windows #227

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Correctly extract parent path on Windows #227

merged 4 commits into from
Oct 12, 2023

Conversation

fzhinkin
Copy link
Collaborator

Previously, shared native Path.parent implementation could filter out a windows path using \ as a separator.

This behavior was fixed to correctly process paths using both \ and / on Windows.

Fixes #221

@fzhinkin fzhinkin added the bug label Oct 11, 2023
@fzhinkin fzhinkin marked this pull request as ready for review October 11, 2023 14:08
@fzhinkin fzhinkin linked an issue Oct 11, 2023 that may be closed by this pull request
Path.parent doesn't work with default Windows path separator #221
Closed
@fzhinkin fzhinkin merged commit 5d8982c into develop Oct 12, 2023
1 check passed
@fzhinkin fzhinkin deleted the fix-path-parent-on-win branch October 12, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshin shanshin shanshin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path.parent doesn't work with default Windows path separator
2 participants
@fzhinkin @shanshin